kalayciburak opened a new pull request, #1265:
URL: https://github.com/apache/poi/pull/1265

   ## What this PR does
   
   `PackagingURIHelper.getRelationshipPartName()` used `URI.getPath()`, which 
decodes percent-encoding. A part name such as `/aasx/test%20document.txt` then 
became `/aasx/test document.txt`, `createPartName` threw 
`InvalidFormatException`, and the method returned `null`.
   
   Use `URI.getRawPath()` (and take the filename from that raw path) so the 
relationship part name stays a valid URI: 
`/aasx/_rels/test%20document.txt.rels`.
   
   Fixes #1264
   
   ## Tests
   
   Executed:
   
   - `./gradlew :poi-ooxml:test --tests 
org.apache.poi.openxml4j.opc.TestPackagePartName` — 3/0
   - `./gradlew :poi-ooxml:test --tests 
org.apache.poi.openxml4j.opc.TestPackagePartName --tests 
org.apache.poi.openxml4j.opc.TestRelationships --tests 
org.apache.poi.openxml4j.opc.compliance.TestOPCCompliancePartName --tests 
org.apache.poi.openxml4j.opc.TestPackage` — 66 completed, 1 skipped, 0 failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to