pjfanning commented on PR #1265: URL: https://github.com/apache/poi/pull/1265#issuecomment-5653859039
Thanks @kalayciburak - could you have a look at this? Suggested fix in the same PR: make getSourcePartUriFromRelationshipPartUri operate on relationshipPartUri.getRawPath() (and derive the filename from the raw path the same way this PR does), and add a round-trip test getSourcePartUriFromRelationshipPartUri(getRelationshipPartName(p).getURI()) == p.getURI() for /aasx/test%20document.txt. Without that, the PR's claim of fixing #1264 only holds for the narrow read-side lookup. No other correctness issues found in the diff. Findings: - poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/PackagingURIHelper.java:647 — inverse getSourcePartUriFromRelationshipPartUri (line 457) still decodes the path, so ZipPartMarshaller.marshall/OPCPackage.save and OPCPackage.removePart still throw (IllegalArgumentException: path) for percent-encoded part names; the #1264 scenario remains broken on the write side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
