pjfanning commented on code in PR #1271:
URL: https://github.com/apache/poi/pull/1271#discussion_r4041310066
##########
poi/src/main/java/org/apache/poi/ss/usermodel/CellValue.java:
##########
@@ -23,8 +23,12 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
* Mimics the 'data view' of a cell. This allows formula evaluator
* to return a CellValue instead of precasting the value to String
* or Number or boolean type.
+ *
+ * Consider {@link LightCellValue} for new code: it is a sealed, memory-leaner
+ * counterpart of this class that CellValue itself implements.
*/
-public final class CellValue {
+// @Deprecated
Review Comment:
I disagree and actually this change is not even needed in this PR. I'm in no
hurry to merge this. This whole evaluator looks like it can live in Apache Hop
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
