rmannibucau commented on code in PR #1271:
URL: https://github.com/apache/poi/pull/1271#discussion_r4041432333
##########
poi/src/main/java/org/apache/poi/ss/usermodel/CellValue.java:
##########
@@ -23,8 +23,12 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
* Mimics the 'data view' of a cell. This allows formula evaluator
* to return a CellValue instead of precasting the value to String
* or Number or boolean type.
+ *
+ * Consider {@link LightCellValue} for new code: it is a sealed, memory-leaner
+ * counterpart of this class that CellValue itself implements.
*/
-public final class CellValue {
+// @Deprecated
Review Comment:
will not, current Hop proposal is to keep apache poi and flag it as such and
too slow for more than a few line and create a new formula component for the
rest totally unrelated....also means we loose excel syntax which is not great.
can you explain why you do disagree since it is not redundant and consumes
x2 memory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]