pjfanning opened a new pull request, #1378: URL: https://github.com/apache/poi/pull/1378
`OpcOutputStream` is the package-private zip writer behind `OpcZipArchiveOutputStream`, which SXSSF uses to save workbooks. Only `write(byte[], int, int)` was `synchronized`, which was copied from `java.util.zip.ZipOutputStream`. `putNextEntry`, `closeEntry` and `finish` update the same state without a lock, and the stream is only ever used by one thread. So the lock protected nothing and was taken on every write while saving. It's also behind the SpotBugs AT_NONATOMIC_64BIT_PRIMITIVE / AT_NONATOMIC_OPERATIONS_ON_SHARED_VARIABLE warnings on `written`. The `xssf.streaming` tests pass, except the auto-size column-width check that depends on local font metrics. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
