naruto-lgtm commented on PR #1577: URL: https://github.com/apache/poi/pull/1577#issuecomment-7059212062
Reworked in 934d603 along the lines of your comments. The one cost left is that an id which isn't a relationship still scans `hyperlinks` linearly, the same as trunk's first loop, but it no longer rebuilds anything. With 20,000 relationships and 20,000 unknown ids, the whole test (build, write/read, extract) takes 4.5 s, against 114 s for extraction alone on trunk. The xwpf tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
