naruto-lgtm commented on code in PR #1577:
URL: https://github.com/apache/poi/pull/1577#discussion_r4651318075


##########
poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFDocument.java:
##########
@@ -223,6 +228,44 @@ void testAddHyperlink() throws IOException {
         }
     }
 
+    /**
+     * Looking up an id that isn't a hyperlink relationship must not rebuild 
the hyperlink list,
+     * otherwise a document with n such links and n hyperlink relationships 
takes O(n^2) to extract
+     */
+    @Test
+    void testUnknownHyperlinkIds() throws Exception {
+        final int count = 10_000;

Review Comment:
   Lowered to 2,000. With the timeout gone the count only has to be large 
enough to be a realistic document, and the test runs in about 0.4 s now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to