Yes, it was what I pointed out (several binary files in the source distribution).
It's totally acceptable because it's for site/documentation, and it's not executable. Regards JB On Wed, Nov 20, 2024 at 12:23 PM Alex Dutra <alex.du...@dremio.com.invalid> wrote: > > Hi all, > > +1 (nb), but with some caveats: I tested signatures, checksums, and ran > tests and license checks. All OK. > > But I found some non-empty binary files: > > > find . -type f ! -size 0 | perl -lne 'print if -B' > ./site/static/favicons/favicon.ico > ./site/static/favicons/android-chrome-192x192.png > ./site/static/favicons/apple-touch-icon.png > ./site/static/favicons/android-chrome-maskable-512x512.png > ./site/static/favicons/favicon.png > ./site/static/favicons/android-chrome-512x512.png > ./site/static/favicons/android-chrome-maskable-192x192.png > ./site/static/img/Polaris-Catalog-BLOG-symmetrical-subhead.png > ./site/static/img/logos/polaris-brandmark.png > ./site/static/img/logos/Polaris-Catalog-BLOG-symmetrical-subhead.png > ./site/static/img/logos/polaris-favicon.png > ./site/static/img/quickstart/privilege-illustration-1.png > ./site/static/img/quickstart/privilege-illustration-2.png > > I think this is fine because these are not executable binary files. But it > would be good if someone more knowledgeable than me on these matters could > confirm. > > Thanks, > > Alex > > On Tue, Nov 19, 2024 at 5:37 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > Actually, reverting my vote to +1 (binding) > > > > NB > > - .keep and .typed are actually empty files (even if flagged as > > binary), so not a problem > > - I will fix all gradle related issue during release process and > > documentation (already working on fix about digest sourceTarball and > > Maven publication) > > > > Regards > > JB > > > > On Tue, Nov 19, 2024 at 6:04 AM Jean-Baptiste Onofré <j...@nanthrax.net> > > wrote: > > > > > > -1 (binding) > > > > > > I found that the source distribution includes binaries, especially > > > gradlew, .keep, *.typed, it has to excluded from the source > > > distribution > > > > > > I will cancel this vote to fix that in rc2. > > > > > > Regards > > > JB > > > > > > On Sun, Nov 17, 2024 at 7:00 AM Jean-Baptiste Onofré <j...@nanthrax.net> > > wrote: > > > > > > > > Hi everyone, > > > > > > > > I propose that we release the following RC as the official Apache > > > > Polaris 0.9.0-incubating release. > > > > > > > > * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc1 > > > > * > > https://github.com/apache/polaris/commits/apache-polaris-0.9.0-incubating-rc1 > > > > * > > https://github.com/apache/polaris/tree/445c42768d1e3148c912ac5c45ee53036b9ef318 > > > > > > > > The release tarball, signature, and checksums are here: > > > > * > > https://dist.apache.org/repos/dist/dev/incubator/polaris/0.9.0-incubating/ > > > > > > > > You can find the KEYS file here: > > > > * https://dist.apache.org/repos/dist/release/incubator/polaris/KEYS > > > > > > > > Convenience binary artifacts are staged on Nexus. The Maven repository > > URL is: > > > > * > > https://repository.apache.org/content/repositories/orgapachepolaris-1003/ > > > > > > > > Please download, verify, and test. > > > > > > > > Please vote in the next 72 hours. > > > > [ ] +1 Release this as Apache polaris 0.9.0-incubating > > > > [ ] +0 > > > > [ ] -1 Do not release this because... > > > > > > > > Only PPMC members and mentors have binding votes, but other community > > > > members are > > > > encouraged to cast non-binding votes. This vote will pass if there are > > > > 3 binding +1 votes and more binding +1 votes than -1 votes. > > > > > > > > NB: if this vote passes, a new vote will be started on the Incubator > > > > general mailing > > > > list. > > > > > > > > Thanks > > > > Regards > > > > JB > >
