-1 because I think I’ve found copied source code that is not documented in the LICENSE file. I grepped for [Cc]opied and found that there are several mustache files that were copied from openapi-generator that are not documented in LICENSE. The openapi-generator project has an ALv2 LICENSE file with the following copyright:
Copyright 2018 OpenAPI-Generator Contributors ( https://openapi-generator.tech) Copyright 2018 SmartBear Software I didn’t find any other copied code, but I would encourage others to grep for phrases like “copied” to help us catch and document these. I also ran across the site folder that contains the Hugo site. I don’t think it is a problem to include the site, but I would generally recommend preventing other content in the repo from being included in the tarball. That makes the source tarball smaller (i.e. not sending blog posts and images in it) and also avoids potential problems in the future, where unrelated content (like build directories with third-party code) is included in the ASF release. In Iceberg, we limit what is in the tarball using git archive --worktree-attributes and a .gitattributes file that ignores certain patterns. Otherwise the release looks good. I checked: - Validated signature and checksum - Ran RAT checks - Checked the disclaimer - Checked that the binary license issues are no longer present (thanks, JB!) - Checked NOTICE content against entries in LICENSE (I don’t see anything to carry over from gradle) - Checked LICENSE updates about gradle (looks good) On Mon, Jan 27, 2025 at 2:07 PM Russell Spitzer <russell.spit...@gmail.com> wrote: > +1 (binding) > > Verified > Checksum > Signatures - Note that me and JB need to verify each other's keys next time > we meet in person :) > Build and Test > Used runApp and poked to make sure nothing was broken > > On Thu, Jan 23, 2025 at 6:41 PM Dmitri Bourlatchkov <di...@apache.org> > wrote: > > > +1 (ns) > > > > Verified: > > * Checksum > > * Signarures > > * ./gradlew clean assemble > > * ./gradlew test > > * Start with in-memory MetaStore > > * Create catalog via ./polaris CLI with FILE storage > > * Basic create table / select in Spark > > > > Cheers, > > Dmitri. > > > > On Wed, Jan 22, 2025 at 3:51 AM Jean-Baptiste Onofré <j...@nanthrax.net> > > wrote: > > > > > Hi folks, > > > > > > Following the NOTICE/LICENSE fix and the issue found on > > > TestPolarisVersion in rc3, we fixed the test compilation issue. > > > > > > This is the vote for Apache Polaris 0.9.0-incubating rc4. > > > > > > * This corresponds to the tag: apache-polaris-0.9.0-incubating-rc4 > > > * > > > > > > https://github.com/apache/polaris/tree/apache-polaris-0.9.0-incubating-rc4 > > > * > > > > > > https://github.com/apache/polaris/tree/37936f5157b37b8b7db2b8b1ebb86d9d067a353e > > > > > > The release source tarball, signature, and checksums are here: > > > * > > > > > > https://dist.apache.org/repos/dist/dev/incubator/polaris/0.9.0-incubating/ > > > > > > You can find the KEYS file here: > > > * https://dist.apache.org/repos/dist/release/incubator/polaris/KEYS > > > > > > NB: this release doesn't provide any binary distribution, it provides > > > source distribution only. > > > > > > Please download, verify, and test. > > > > > > Please vote in the next 72 hours. > > > [ ] +1 Release this as Apache polaris 0.9.0-incubating > > > [ ] +0 > > > [ ] -1 Do not release this because... > > > > > > Only PPMC members and mentors have binding votes, but other community > > > members are encouraged to cast non-binding votes. This vote will pass > > > if there are > > > 3 binding +1 votes and more binding +1 votes than -1 votes. > > > > > > NB: if this vote passes, a new vote will be started on the Incubator > > > general mailing list. > > > > > > Thanks > > > Regards > > > JB > > > > > >
