+1 for the change and +1 for the changelog. Thanks Adnan!

On Fri, Sep 19, 2025 at 7:39 PM Yufei Gu <[email protected]> wrote:
>
> +1 Thanks for working on this, Adnan! It's also nice to mention it in the
> changelog as Dmitri pointed out.
>
> Yufei
>
>
> On Fri, Sep 19, 2025 at 8:58 AM Dmitri Bourlatchkov
> <[email protected]> wrote:
>
> > +0 As I commented in GH, code changes LGTM (as of commit f0b6896), but I
> > believe we ought to mention the change in API behaviour in CHANGELOG.md
> >
> > Cheers,
> > Dmitri.
> >
> > On Thu, Sep 18, 2025 at 9:46 PM Adnan Hemani
> > <[email protected]> wrote:
> >
> > > Hi all,
> > >
> > > I propose that we make a change to the OpenAPI spec to return the newly
> > > created object in each of the following APIs: createCatalog,
> > > createPrincipalRole, and createCatalogRole.
> > >
> > > ML thread regarding this topic here <
> > > https://lists.apache.org/thread/q7q0rrsmw5gcqv30g4hr9ffq3gtr72yk>. A
> > > draft PR detailing these changes can be found here <
> > > https://github.com/apache/polaris/pull/2603>.
> > >
> > > Please vote in the next 72 hours.
> > >
> > > [ ] +1 Make the proposed API change.
> > > [ ] +0
> > > [ ] -1 Do not make this change because…
> > >
> > > Only PPMC members and mentors have binding votes, but other community
> > > members are encouraged to cast non-binding votes. This vote will pass if
> > > there are 3 binding +1 votes and more binding +1 votes than -1 votes.
> > >
> > > Best,
> > > Adnan Hemani
> >

Reply via email to