Hi James,

Florian said it already. This was just a function declaration. Removing it does no harm. I did completely replace all Mac OS X specific dylib code in favor of the standard Unix dylib set of API's as suggested by Apple. This way we get rid of some platform specific code, gain thread safety and less Mac OS X speccific maintainance effort. Of course should every dlopen call be matched by a corresponding dlclose call. That's the responsibility of the caller.

Kind regards,
Tino

James Mckenzie wrote:
tra:

Does this code work?
I think that the #ifdef, else, endif should be dropped and the dlclose line 
restored (it appears that a file is being closed here.)

This is the line needing restoration, unless it is implemented elsewhere in the 
code block:

extern int _dlclose(void *handle);

James McKenzie

-----Original Message-----
From: [EMAIL PROTECTED]
Sent: Oct 29, 2005 6:38 AM
To: [EMAIL PROTECTED]
Subject: [porting-cvs] CVS update [cws_src680_macosx20xfixes01]: 
/porting/sal/osl/unx/

Tag: cws_src680_macosx20xfixes01
User: tra Date: 05/10/29 06:38:01

Modified:
 /porting/sal/osl/unx/
  module.c

Log:
 #i55863#Removed Mac OS X specific code in favor of the standard Unix dylib 
functions

File Changes:

Directory: /porting/sal/osl/unx/
================================

File [changed]: module.c
Url: 
http://porting.openoffice.org/source/browse/porting/sal/osl/unx/module.c?r1=1.31.34.1&r2=1.31.34.2
Delta lines:  +3 -6
-------------------
--- module.c    27 Oct 2005 18:37:10 -0000      1.31.34.1
+++ module.c    29 Oct 2005 13:37:58 -0000      1.31.34.2
@@ -4,9 +4,9 @@
  *
  *  $RCSfile: module.c,v $
  *
- *  $Revision: 1.31.34.1 $
+ *  $Revision: 1.31.34.2 $
  *
- *  last change: $Author: tra $ $Date: 2005/10/27 18:37:10 $
+ *  last change: $Author: tra $ $Date: 2005/10/29 13:37:58 $
  *
  *  The Contents of this file are made available subject to
  *  the terms of GNU Lesser General Public License Version 2.1.
@@ -91,10 +91,7 @@
#ifdef MACOSX
 #include </usr>
-extern oslProcessError SAL_CALL osl_searchPath(const sal_Char* pszName, const 
sal_Char* pszPath, sal_Char Separator, sal_Char *pszBuffer, sal_uInt32 Max);
-#else /* MACOSX */
-extern int _dlclose(void *handle);
-#endif /* MACOSX */
+#endif
/* implemented in file.c */
 extern int UnicodeToText(char *, size_t, const sal_Unicode *, sal_Int32);




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to