Hi Takashi, On Thursday, 2008-04-10 21:34:24 +0900, Takashi Ono wrote:
> >How is sal_Unicode related to ICU? ICU doesn't use sal_Unicode. > > > > With the configure script that comes with icu distribution, icu prefer using > wchar_t > to represent unicode with wchar_t if wchar_t is available and is a 16 bit > integer > type. So the pointer to UChar is not compatible with sal_Unicode unless we do > not use > reinterpret_cast's > [...] > >static_cast where? In ICU? According to > > >http://source.icu-project.org/repos/icu/icu/tags/release-3-8-1/readme.html#HowToBuildSupported > >MinGW is supported but rarely tested. Patches necessary to make it build > >should be upstreamed. > > > > It is buildable with MinGW tools but we have to use reinterpret_cast > whereever we > assign a pointer to UChar to a pointer to sal_Unicode. Do you know off-hand or could give me a pointer where assigning UChar* to sal_Unicode* or vice versa was done? I consider relying on such implementation detail a misuse ... if it wasn't for very good reason. > >> and make dll's to have similar names to MSVC build are also included. > > > >Those of course wouldn't make it upstream. Is that really needed? > >Shouldn't it be better addressed in solenv/inc/libs.mk and packaging? > > > > It is possible but we have to have many conditionals there and some OOo > developpers > may not like it. I have had a comment that the commenter likes to have even > less. And I want to have less patches against ICU ;-) Having conditionals or macros in libs.mk and packaging would probably be a one-time effort with little maintenance needed, while platform patches against ICU would had to be reapplied and maintained for every ICU upgrade. Given the awful unstructured all-in-one patch bulk I consider having to handle that much worse than any "I don't like conditionals" comment. Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to the [EMAIL PROTECTED] account, which I use for mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] Thanks.
pgpMQhEdI8W44.pgp
Description: PGP signature
