Hi Takashi, On Friday, 2008-04-18 06:21:11 +0900, Takashi Ono wrote:
> >Do you know off-hand or could give me a pointer where assigning UChar* > >to sal_Unicode* or vice versa was done? I consider relying on such > >implementation detail a misuse ... if it wasn't for very good reason. > > > > In both line #185 and 186 in > i18npool/source/breakiterator/breakiterator_unicode.cxx, > constructor of UnicodeString, which requires const UChar* as a 1st argument, > is > called with const sal_Unicode* string. That indeed should be changed. Thanks for the pointer. Is that the only place where you encountered such type mismatch? > I may be possible to implement a switch in icu configure script to force > using > unsigned short instead of wchar_t and propose it upstream. But not using wchar_t wouldn't go with the Windows API, would it? > >[... conditionals in build environment vs. bulk patches ...] > > I think your coment makes sense and will not implement more modifications in > patches > for 3rd party modules to have less conditionals elsewhere. Probably I can > make the > patch for icu a bit smaller in the future with the strategy. Sounds promising :-) Thanks Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to the [EMAIL PROTECTED] account, which I use for mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] Thanks.
pgp4NS8XGS9oi.pgp
Description: PGP signature
