ASF GitHub Bot commented on PIO-47:

Github user chanlee514 commented on a diff in the pull request:

    --- Diff: 
core/src/main/twirl/org/apache/predictionio/workflow/index.scala.html ---
    @@ -65,13 +63,6 @@
             <tr><th>Average Serving Time</th><td>@{f"${avgServingSec}%.4f"} 
             <tr><th>Last Serving Time</th><td>@{f"${lastServingSec}%.4f"} 
             <tr><th>Engine Factory Class 
    -        <tr>
    --- End diff --
    Maybe we can search for the relevant .jar files in engine target/ directory?

> Remove engine manifest for stateless build
> ------------------------------------------
>                 Key: PIO-47
>                 URL: https://issues.apache.org/jira/browse/PIO-47
>             Project: PredictionIO
>          Issue Type: New Feature
>            Reporter: Chan
> As discussed in the dev mailing list, removing engine manifest would be the 
> first step in improving the workflow towards a more modular design. 
> - Remove manifest.json completely. `pio build` will be stateless, and will 
> not write anything to the database. This will make it easier to compile/build 
> on PaaS platforms such as Heroku. Later, we can remove `pio build` command 
> entirely, so that PIO is independent of the build tool (sbt).
> - An immediate major disadvantage would be not being able to run pio commands 
> outside of the engine directory. This can be resolved in the next step of 
> creating a general metadata registry.
> - Meanwhile, we can use engineFactory as *engineId* , and SHA-1 hash of 
> engine filepath as *engineVersion* (as before). We can improve this when 
> designing a metadata registry, 

This message was sent by Atlassian JIRA

Reply via email to