sijie commented on a change in pull request #159:
URL: https://github.com/apache/pulsar-helm-chart/pull/159#discussion_r704185333
##########
File path: charts/pulsar/templates/bookkeeper-service.yaml
##########
@@ -33,7 +33,7 @@ metadata:
spec:
ports:
- name: bookie
- port: {{ .Values.bookkeeper.ports.bookie }}
Review comment:
I don't think it breaks any compatibility. Because it can easily upgrade
and roll back.
An alternative approach is to add a "portPrefix". By default it is `""`. But
users can override it with "tcp-”.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
