lhotari commented on a change in pull request #159:
URL: https://github.com/apache/pulsar-helm-chart/pull/159#discussion_r704342473
##########
File path: charts/pulsar/templates/bookkeeper-service.yaml
##########
@@ -33,7 +33,7 @@ metadata:
spec:
ports:
- name: bookie
- port: {{ .Values.bookkeeper.ports.bookie }}
Review comment:
It seems that my comment about the keys and backwards compatibility
needs clarification. For changing the port names, it shouldn't be necessary to
change the content of the values yaml format at all. That's what my original
comment was about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
