Github user jai1 commented on a diff in the pull request:
https://github.com/apache/incubator-pulsar/pull/539#discussion_r124726012
--- Diff: pulsar-client-cpp/tests/BasicEndToEndTest.cc ---
@@ -578,8 +578,13 @@ TEST(BasicEndToEndTest,
testSinglePartitionRoutingPolicy)
consumer.receive(m);
consumer.acknowledgeCumulative(m);
}
+
+ Promise<bool, Result> closePromise;
+ Result r;
consumer.close();
- producer.closeAsync(0);
+ producer.closeAsync(WaitForCallback(closePromise));
--- End diff --
We can but closeAsync was used in an effort to increase code coverage of
CPP Unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---