Github user merlimat commented on a diff in the pull request:

    https://github.com/apache/incubator-pulsar/pull/539#discussion_r124853117
  
    --- Diff: pulsar-client-cpp/tests/BasicEndToEndTest.cc ---
    @@ -578,8 +578,13 @@ TEST(BasicEndToEndTest, 
testSinglePartitionRoutingPolicy)
             consumer.receive(m);
             consumer.acknowledgeCumulative(m);
         }
    +
    +    Promise<bool, Result> closePromise;
    +    Result r;
         consumer.close();
    -    producer.closeAsync(0);
    +    producer.closeAsync(WaitForCallback(closePromise));
    --- End diff --
    
    the implementation of `Producer.close()` is exactly the same, so it will 
exercise the same code path: 
    
    ```cpp
    Result Producer::close() {
        Promise<bool, Result> promise;
        closeAsync(WaitForCallback(promise));
    
        Result result;
        promise.getFuture().get(result);
        return result;
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to