jai1 commented on a change in pull request #577: CPP add receiveAsync API
URL: https://github.com/apache/incubator-pulsar/pull/577#discussion_r128060137
##########
File path: pulsar-client-cpp/lib/ConsumerImpl.h
##########
@@ -135,6 +137,7 @@ enum ConsumerTopicType {
ExecutorServicePtr listenerExecutor_;
ConsumerTopicType consumerTopicType_;
UnboundedBlockingQueue<Message> incomingMessages_;
+ UnboundedBlockingQueue<ReceiveCallback> pendingReceives_;
Review comment:
UnboundedBlockingQueue is not a good idea, since you don't want to block if
the queue is empty
I would suggest using a vector or a list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
