jai1 commented on a change in pull request #577: CPP add receiveAsync API
URL: https://github.com/apache/incubator-pulsar/pull/577#discussion_r128071400
##########
File path: pulsar-client-cpp/lib/ConsumerImpl.cc
##########
@@ -271,19 +272,39 @@ void ConsumerImpl::messageReceived(const
ClientConnectionPtr& cnx, const proto::
unsigned int numOfMessageReceived = 1;
if (metadata.has_num_messages_in_batch()) {
- Lock lock(mutex_);
Review comment:
A. Yes I need the mutex since batchAcknowledgementTracker_ is not thread safe
B. As discussed - I don't see a deadlock
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
