rdhabalia commented on a change in pull request #634: PIP-3 : Introduce 
message-dispatch rate limiting
URL: https://github.com/apache/incubator-pulsar/pull/634#discussion_r132026790
 
 

 ##########
 File path: 
pulsar-common/src/main/java/org/apache/pulsar/common/util/RateLimiter.java
 ##########
 @@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.common.util;
+
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.ScheduledThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
+import static com.google.common.base.Preconditions.checkArgument;
+
+/**
+ * 
+ * A Rate Limiter that distributes permits at a configurable rate. Each {@link 
#acquire()} blocks if necessary until a
+ * permit is available, and then takes it. Each {@link #tryAcquire()} tries to 
acquire permits from available permits,
+ * it returns true if it succeed else returns false. Rate limiter release 
configured permits at every configured rate
+ * time, so, on next ticket new fresh permits will be available.
+ * <p>
+ * For example: if RateLimiter is configured to release 10 permits at every 1 
second then RateLimiter will allow to
+ * acquire 10 permits at any time with in that 1 second.
+ *
+ */
+public class RateLimiter {
 
 Review comment:
   I have started with `Guava-RateLimiter` but ended up with custom one due to 
2 main reasons:
   (1) achieve per-second rate-limiting and (2) custom is faster compare to 
guava. I have added both [Explanation 
here](https://gist.github.com/rdhabalia/324519648b8a1008ef49d30c8f4a8bf2)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to