Seems to me you could do an experiment and see. If it is not to the podling's liking then ask Infra to fix.
Regards, Dave Sent from my iPhone > On Aug 10, 2017, at 9:48 PM, Masakazu Kitajo <mas...@apache.org> wrote: > >> On Fri, Aug 11, 2017 at 6:38 AM, Matteo Merli <mme...@apache.org> wrote: >> >> Hi Masakazu, >> >>> Look at the second commit. The commit is made by GitHub < >> nore...@github.com> >> >> I think that this happens when the author of the commit is pushing the >> "merge" button on its own commit (after having received +1s from other >> committers).. >> > > Actually it doesn't happen on Traffic Server project, even if the author > pushes the merge button. This is why I noticed the difference. > > >> In this case: >> >>> commit 2b63573eea220a8710a93d87f451188e0f253b22 >>> Author: Matteo Merli <mme...@apache.org> >>> Commit: GitHub <nore...@github.com> >> >> I submitted the PR and then merged it. Though if I merge someone else's PR, >> my name/email will appear in the "Commit" field. eg: >> >>> commit de24aaf11ce61f8af28bb1dd70c099a8e43d0f08 >>> Refs: >>> Author: hrsakai <hsa...@yahoo-corp.jp> >>> AuthorDate: Wed Aug 9 15:28:04 2017 +0900 >>> Commit: Matteo Merli <mme...@apache.org> >>> CommitDate: Tue Aug 8 23:28:04 2017 -0700 >>> >>> support tls in performance tool (#662) >> >> I think that should be fine, given that is clear who authored the change >> and who made the commit. >> >> > That's only true if we know a rule that noreply means the author and > committer are the same person. It's OK with me, but is it also OK with ASF, > Mentors? > > >> Having said that, I would suggest for all committers to use the proper >> "first-name last-name" and apache >> email in the commit signatures. Also, please add that in Github as well, so >> that it will be used when >> you merge PRs from the github interface. >> >> Matteo >> >> >> >> >>> On Tue, Aug 8, 2017 at 5:26 AM Masakazu Kitajo <mas...@apache.org> wrote: >>> >>> Committers, >>> >>> It seems some commits doesn't have a valid committer name. It's not cool. >>> >>> I couldn't find any official rules but some (most?) projects require to >> use >>> your email address as a committer when you push commits. We should >> probably >>> do this. IIRC, you can set the address at GitHub Settings - Email - >> Primary >>> email address, and it need to be public. >>> >>> Look at the second commit. The commit is made by GitHub < >>> nore...@github.com >>>> . >>> >>> $ git log --pretty=full >>> >>> commit d2ab2b599210dff5d2551a3cab875a8d7ef4a3a0 (HEAD -> master, >>> apache/master) >>> Author: Luc Perkins <lucperk...@gmail.com> >>> Commit: Masakazu Kitajo <mas...@apache.org> >>> >>> Add link checker and fix broken links (#647) >>> >>> * add htmltest link checker setup steps and fix a few links >>> >>> * add license header to new script >>> >>> * add license header to htmltest YAML config file >>> >>> * fix Makefile and some broken links >>> >>> commit 2b63573eea220a8710a93d87f451188e0f253b22 >>> Author: Matteo Merli <mme...@apache.org> >>> Commit: GitHub <nore...@github.com> >>> >>> Build website using the current user rather than root (#652) >>> >> -- >> Matteo Merli >> <mme...@apache.org> >> > > Thanks. > Masakazu
