+1
Environment: MacOS 10.13
Checked:
* Signatures, crc
* Bin distribution:
- NOTICE, README, LICENSE
- Start standalone service and producer/consumer test
* Src distribution:
- NOTICE, README, LICENSE
- Compile and unit tests
- RAT check
- Start standalone service
* Checked staging maven repository artifacts
Matteo
On Mon, Jul 23, 2018 at 3:06 PM Jerry Peng <jerry.boyang.p...@gmail.com>
wrote:
> +1 for the 5th release candidate for Apache Pulsar, version
> 2.1.0-incubating
>
> Source and binary files:
>
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
>
> I followed the release candidate validation guide:
>
>
> https://github.com/apache/incubator-pulsar/wiki/Release-Candidate-Validation
>
>
> Verified the following to be working:
>
> * Validate Pub/Sub
> * Validate Java Functions
> * Validate Connectors
> * Validate Stateful Functions
>
> On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher <dave2w...@comcast.net>
> wrote:
>
> > Hi -
> >
> > +1 (IPMC Binding)
> >
> > Comment #1 - There are many more files to review in this release. :-)
> >
> > (1) Source release.
> > Signature and checksums pass.
> > Builds from source with the option that Sijie provided.
> > Standalone starts
> > NOTICE, LICENSE and DISCLAIMER look good.
> >
> > (2) Binary release
> > Signature and checksums pass.
> > Standalone starts
> > NOTICE, LICENSE and DISCLAIMER look good.
> >
> > (3) Pulsar IO Connectors NAR files.
> > Signature and checksums pass.
> > LICENSE and DISCLAIMER exist in the top level of the package.
> > LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files.
> >
> > ==> DISCLAIMER should be included in the NAR files.
> > ==> NOTICE should also be at the top level.
> >
> > (4) DEB
> > Signature and checksums pass
> > NOTICE, LICENSE, and DISCLAIMER look good.
> >
> > ==> copyright files contain the Apache License. IMO these ought to
> contain
> > the NOTICE
> >
> > (5) RPM
> > Signature and checksums pass
> > NOTICE, LICENSE, and DISCLAIMER look good.
> >
> > ==> I’m curious about how the sqlite binary files are used.
> >
> > Regards,
> > Dave
> >
> > > On Jul 22, 2018, at 10:05 PM, Sijie Guo <guosi...@gmail.com> wrote:
> > >
> > > any more review comments?
> > >
> > > - Sijie
> > >
> > > On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo <guosi...@gmail.com> wrote:
> > >
> > >> Okay will remove it.
> > >>
> > >> But just to clarify, the KEYS file I put in the voting email is the
> one
> > >> used for releases, the one contains my KEY. Please use the one in
> voting
> > >> email to verify.
> > >>
> > >> - Sijie
> > >>
> > >> On Fri, Jul 20, 2018 at 1:07 PM Dave Fisher <dave2w...@comcast.net>
> > wrote:
> > >>
> > >>> Hi Sijie,
> > >>>
> > >>> I was looking at the KEYS here:
> > >>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/KEYS
> > >>>
> > >>> Probably that should be removed or updated from the release version.
> > >>>
> > >>> Regards,
> > >>> Dave
> > >>>
> > >>>> On Jul 20, 2018, at 12:58 PM, Sijie Guo <guosi...@gmail.com> wrote:
> > >>>>
> > >>>> HI Dave,
> > >>>>
> > >>>> My key is already there :
> > >>>> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> > >>>>
> > >>>> Search "Sijie Guo"
> > >>>>
> > >>>> - Sijie
> > >>>>
> > >>>>
> > >>>>
> > >>>> On Fri, Jul 20, 2018 at 11:47 AM Dave Fisher <dave2w...@comcast.net
> >
> > >>> wrote:
> > >>>>
> > >>>>> Hi Sijie,
> > >>>>>
> > >>>>> Please add your key to the KEYS file.
> > >>>>>
> > >>>>> Regards,
> > >>>>> Dave
> > >>>>>
> > >>>>>> On Jul 19, 2018, at 4:43 PM, Sijie Guo <si...@apache.org> wrote:
> > >>>>>>
> > >>>>>> This is the 5th release candidate for Apache Pulsar, version
> > >>>>>> 2.1.0-incubating.
> > >>>>>>
> > >>>>>> It introduces following main features:
> > >>>>>>
> > >>>>>> - Pulsar I/O: a serverless connector framework built on top of
> > Pulsar
> > >>>>>> Functions.
> > >>>>>> - TieredStorage: offloads bookkeeper ledgers to a cold storage
> (like
> > >>> S3).
> > >>>>>> - Stateful Function: Pulsar Functions supports storing state back
> to
> > >>>>>> bookkeeper.
> > >>>>>> - Go Client: a Go client wrapping over existing cpp client.
> > >>>>>> - Avro and Protobuf schema are supported.
> > >>>>>>
> > >>>>>> Full list of changes and fixes are available:
> > >>>>>>
> > >>>>>> https://github.com/apache/incubator-pulsar/milestone/13?closed=1
> > >>>>>>
> > >>>>>> *** Please download, test and vote on this release. This vote will
> > >>> stay
> > >>>>> open
> > >>>>>> for at least 72 hours ***
> > >>>>>>
> > >>>>>> Note that we are voting upon the source (tag), binaries are
> provided
> > >>> for
> > >>>>>> convenience.
> > >>>>>>
> > >>>>>> Source and binary files:
> > >>>>>>
> > >>>>>
> > >>>
> >
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/
> > >>>>>>
> > >>>>>> SHA-1 checksums:
> > >>>>>>
> > >>>>>> f0f6b6d7c48d119da36fc4fa1f934fd1f9ba8498
> > >>>>>> ./apache-pulsar-2.1.0-incubating-bin.tar.gz
> > >>>>>>
> > >>>>>> b6a968249a7c5d21be89ece27895b862efda9a92
> > >>>>>> ./apache-pulsar-2.1.0-incubating-src.tar.gz
> > >>>>>>
> > >>>>>> ddcf929eb18082ff2b9979507054453e8e803ed3
> > >>>>>> ./apache-pulsar-io-connectors-2.1.0-incubating-bin.tar.gz
> > >>>>>>
> > >>>>>>
> > >>>>>> Maven staging repo:
> > >>>>>>
> > >>>
> > https://repository.apache.org/content/repositories/orgapachepulsar-1025/
> > >>>>>>
> > >>>>>> The tag to be voted upon:
> > >>>>>> v2.1.0-incubating-candidate-5
> > >>> (75f79b77f55fbad351cb517e7f3b8ba4ab2dc177)
> > >>>>>>
> > >>>>>
> > >>>
> >
> https://github.com/apache/incubator-pulsar/releases/tag/v2.1.0-incubating-candidate-5
> > >>>>>>
> > >>>>>> Pulsar's KEYS file containing PGP keys we use to sign the release:
> > >>>>>> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> > >>>>>>
> > >>>>>> Please download the the source package, and follow the README to
> > build
> > >>>>>> and run the Pulsar standalone service.
> > >>>>>>
> > >>>>>> A few notes for reviewing/voting 2.1.0 release:
> > >>>>>>
> > >>>>>> - Starting from this release, we are shipping RPM & DEB packages
> for
> > >>>>> pulsar
> > >>>>>> non-java clients.
> > >>>>>> - Starting from this release, we are shipping a binary
> distribution
> > >>>>> called
> > >>>>>> `apache-pulsar-io-connectors`
> > >>>>>> including all built-in connectors. Each connector is packaged with
> > all
> > >>>>>> their dependencies and
> > >>>>>> a META-INF/DEPEDENCIES file with licensing information for
> > >>>>>> all dependencies.
> > >>>>>> - Since there are a lot of features introduced in 2.1, I put up an
> > >>>>>> instruction for people to validate release candidate
> > >>>>>> on different features:
> > >>>>>>
> > >>>>>
> > >>>
> >
> https://github.com/apache/incubator-pulsar/wiki/Release-Candidate-Validation
> > >>>>>
> > >>>>>
> > >>>
> > >>>
> >
> >
>
--
Matteo Merli
<mme...@apache.org>
