QPID-2192 is a bug a user raised about the random printStackTrace
calls that are littered about the place. This patch deletes all of the
ones in java/client and java/common I found that they might run into.
I'll commit this on Wednesday if nobody objects. The tests all pass
and they're fairly clearly wrong AFAICT.
- Aidan
--
Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
"A witty saying proves nothing" - Voltaire
From 91f7b106ee105b0159f5c3cfcea6c176c3f75046 Mon Sep 17 00:00:00 2001
From: Aidan Skinner <ai...@apache.org>
Date: Tue, 10 Nov 2009 03:00:02 +0000
Subject: [PATCH] QPID-2192: remove a bunch of extraneous printStackTraces()
---
.../java/org/apache/qpid/client/AMQConnection.java | 1 -
.../java/org/apache/qpid/client/AMQSession.java | 1 -
.../qpid/client/BasicMessageProducer_0_10.java | 2 --
.../qpid/client/message/AbstractJMSMessage.java | 2 --
.../qpid/client/protocol/AMQProtocolHandler.java | 1 -
.../org/apache/qpid/client/state/StateWaiter.java | 1 -
.../client/protocol/AMQProtocolHandlerTest.java | 1 -
.../qpid/transport/network/io/IoReceiver.java | 1 -
8 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java b/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java
index 461f4d0..6dfb70f 100644
--- a/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java
+++ b/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java
@@ -559,7 +559,6 @@ public class AMQConnection extends Closeable implements Connection, QueueConnect
if (connectionException.getCause() != null)
{
message = connectionException.getCause().getMessage();
- connectionException.getCause().printStackTrace();
}
else
{
diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java b/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
index dd9a00c..43f6fd8 100644
--- a/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
+++ b/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java
@@ -1275,7 +1275,6 @@ public abstract class AMQSession<C extends BasicMessageConsumer, P extends Basic
{
JMSException ex = new JMSException("Cannot create temporary queue");
ex.setLinkedException(e);
- e.printStackTrace();
throw ex;
}
}
diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java b/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
index d059850..7215f98 100644
--- a/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
+++ b/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer_0_10.java
@@ -180,8 +180,6 @@ public class BasicMessageProducer_0_10 extends BasicMessageProducer
catch (RuntimeException rte)
{
JMSException ex = new JMSException("Exception when sending message");
- rte.printStackTrace();
- ex.setLinkedException(rte);
throw ex;
}
}
diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java b/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java
index 60c6048..288a4ea 100644
--- a/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java
+++ b/qpid/java/client/src/main/java/org/apache/qpid/client/message/AbstractJMSMessage.java
@@ -402,8 +402,6 @@ public abstract class AbstractJMSMessage implements org.apache.qpid.jms.Message
}
catch (JMSException e)
{
- e.printStackTrace();
-
throw new RuntimeException(e);
}
}
diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java b/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java
index 65d3fa9..505febd 100644
--- a/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java
+++ b/qpid/java/client/src/main/java/org/apache/qpid/client/protocol/AMQProtocolHandler.java
@@ -476,7 +476,6 @@ public class AMQProtocolHandler implements ProtocolEngine
}
catch (Exception e)
{
- e.printStackTrace();
_logger.error("Exception processing frame", e);
propagateExceptionToFrameListeners(e);
exception(e);
diff --git a/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java b/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java
index 4695b19..79f438d 100644
--- a/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java
+++ b/qpid/java/client/src/main/java/org/apache/qpid/client/state/StateWaiter.java
@@ -113,7 +113,6 @@ public class StateWaiter extends BlockingWaiter<AMQState>
{
_logger.error("Failover occured whilst waiting for states:" + _awaitStates);
- e.printStackTrace();
return null;
}
}
diff --git a/qpid/java/client/src/test/java/org/apache/qpid/client/protocol/AMQProtocolHandlerTest.java b/qpid/java/client/src/test/java/org/apache/qpid/client/protocol/AMQProtocolHandlerTest.java
index f520a21..562383a 100644
--- a/qpid/java/client/src/test/java/org/apache/qpid/client/protocol/AMQProtocolHandlerTest.java
+++ b/qpid/java/client/src/test/java/org/apache/qpid/client/protocol/AMQProtocolHandlerTest.java
@@ -178,7 +178,6 @@ public class AMQProtocolHandlerTest extends TestCase
}
catch (Exception e)
{
- e.printStackTrace();
fail(e.getMessage());
}
}
diff --git a/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java b/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java
index ea48e48..6144edb 100644
--- a/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java
+++ b/qpid/java/common/src/main/java/org/apache/qpid/transport/network/io/IoReceiver.java
@@ -137,7 +137,6 @@ final class IoReceiver implements Runnable
}
catch (Throwable t)
{
- t.printStackTrace();
if (!(shutdownBroken &&
t instanceof SocketException &&
t.getMessage().equalsIgnoreCase("socket closed") &&
--
1.6.0.4
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org
