It is 1 character introduced 6 days ago iirc (I was on holiday and so didn't start the broker again until yesterday) in the commit I mentioned. It shouldn't be there (hence warnings from both my own pre-configuration check, and log4j itself during configuration) and it hasn't been there in the years that XML file has existed, but it is now. Currently the file is violating the log4j XML DTD, once the character is removed it is not. I personally think removing it is about as low risk as change gets (it's already removed and tested on a branch if that helps put your mind at ease), and including it will just make us look bad for not catching it during the release process, considering it is plastered all over the broker startup output.
Robbie > -----Original Message----- > From: Andrew Stitcher [mailto:[email protected]] > Sent: 22 December 2009 18:42 > To: [email protected] > Subject: RE: Release 0.6rc1 now in progress: trunk now frozen; tag > created > > On Tue, 2009-12-22 at 18:17 +0000, Robbie Gemmell wrote: > > Whilst I obviously agree the change I mentioned certainly isn't > 'critical' or worth respinning for, I am disappointed you'd consider > doing another spin to pick up the .net patches without remove that 1 > stray character. > > > > I think it's a little tricky. I have no experience base to judge how > low > risk a change in the java area is, so this naturally makes me more > conservative there. > > Also, the changes I'm allowing in wouldn't really require retesting > anything outside c++ clustering and the dotnet client. In theory adding > in your changes means retesting java too, which is a much larger thing > to retest. > > Andrew > > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:[email protected] --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
