On Mon, 2010-01-18 at 09:21 -0500, Andrew Stitcher wrote: > On Fri, 2010-01-15 at 16:48 -0500, Alan Conway wrote: > > There used to be a macro called QPID_TSS which expanded to __thread on gcc > > and > > the equivalent windows decl on windows. > > It appears to be gone, and instead there are naked __thread declarations in > > various places. > > > > Can anyone comment on why its gone? Don't we need that abstraction? > > > It was unfortunately not much of an abstraction and so wasn't really of > any use. I think it got removed when the last thing using it was removed > for the code base.
Ok I take that back, as it's now been found - that's the trouble with writing emails first thing on a Monday morning off the top of your head! > > I'm pretty sure that it turns out (at least presently) that the only > thread specific vars are in platform specific code. And so a macro to > switch between the windows and gcc syntax wasn't actually necessary. And this isn't true either! TSS vars are used by the (platform independent) management code. > > The real TSS abstraction we will need is to support compilers/platforms > that don't have a built in compiler __thread. For instance the Mac OSX > version of gcc. However this is true and more work intrusive than I'd like to do without thinking hard about it. Andrew --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
