[
https://issues.apache.org/jira/browse/DISPATCH-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387574#comment-17387574
]
ASF GitHub Bot commented on DISPATCH-2198:
------------------------------------------
kgiusti commented on a change in pull request #1324:
URL: https://github.com/apache/qpid-dispatch/pull/1324#discussion_r676874357
##########
File path: src/adaptors/http2/http2_adaptor.c
##########
@@ -1330,14 +1314,12 @@ ssize_t read_data_callback(nghttp2_session *session,
if (remaining_payload_length <= QD_HTTP2_BUFFER_SIZE) {
if (length < remaining_payload_length) {
bytes_to_send = length;
- set_buffers_to_send(stream_data, bytes_to_send);
stream_data->full_payload_handled = false;
}
else {
bytes_to_send = remaining_payload_length;
- set_buffers_to_send(stream_data, bytes_to_send);
stream_data->full_payload_handled = true;
- qd_log(http2_adaptor->protocol_log_source,
QD_LOG_TRACE, "[C%"PRIu64"][S%"PRId32"] read_data_callback
remaining_payload_length (%zu) <= QD_HTTP2_BUFFER_SIZE(16384),
bytes_to_send=%zu, stream_data->qd_buffers_to_send=%zu", conn->conn_id,
stream_data->stream_id, remaining_payload_length, bytes_to_send,
stream_data->qd_buffers_to_send);
+ qd_log(http2_adaptor->protocol_log_source,
QD_LOG_TRACE, "[C%"PRIu64"][S%"PRId32"] read_data_callback
remaining_payload_length (%zu) <= QD_HTTP2_BUFFER_SIZE(16384),
bytes_to_send=%zu", conn->conn_id, stream_data->stream_id,
remaining_payload_length, bytes_to_send);
Review comment:
should "remaining_payload_length" covert using %i instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [http2] Implement http2 flow control that incorporates q2 blocking/unblocking
> -----------------------------------------------------------------------------
>
> Key: DISPATCH-2198
> URL: https://issues.apache.org/jira/browse/DISPATCH-2198
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Protocol Adaptors
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.17.0
>
>
> Implement q2 blocking/unblocking in http2 adaptor. When the ingress router is
> q2 blocked, it should simply stop reading from the proton raw connection.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
