[
https://issues.apache.org/jira/browse/DISPATCH-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388279#comment-17388279
] ASF GitHub Bot commented on DISPATCH-2198: ------------------------------------------ codecov-commenter edited a comment on pull request #1324: URL: https://github.com/apache/qpid-dispatch/pull/1324#issuecomment-887067008 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1324](https://codecov.io/gh/apache/qpid-dispatch/pull/1324?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cff9b78) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/6d7e8c2d8bbf1645826064c3bf0074da89366071?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d7e8c2) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #1324 +/- ## ========================================== + Coverage 84.65% 84.67% +0.02% ========================================== Files 113 113 Lines 28375 28376 +1 ========================================== + Hits 24020 24027 +7 + Misses 4355 4349 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.33% <0.00%> (-0.19%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.53% <0.00%> (ø)` | | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `68.68% <0.00%> (+0.06%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.75% <0.00%> (+0.21%)` | :arrow_up: | | [tests/test-sender.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1zZW5kZXIuYw==) | `58.55% <0.00%> (+1.35%)` | :arrow_up: | | [tests/test-receiver.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1324/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGVzdC1yZWNlaXZlci5j) | `71.96% <0.00%> (+2.80%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1324?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1324?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6d7e8c2...cff9b78](https://codecov.io/gh/apache/qpid-dispatch/pull/1324?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > [http2] Implement http2 flow control that incorporates q2 blocking/unblocking > ----------------------------------------------------------------------------- > > Key: DISPATCH-2198 > URL: https://issues.apache.org/jira/browse/DISPATCH-2198 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Protocol Adaptors > Reporter: Ganesh Murthy > Assignee: Ganesh Murthy > Priority: Major > Fix For: 1.17.0 > > > Implement q2 blocking/unblocking in http2 adaptor. When the ingress router is > q2 blocked, it should simply stop reading from the proton raw connection. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
