tabish121 commented on a change in pull request #1:
URL: https://github.com/apache/qpid-protonj2/pull/1#discussion_r695063225
##########
File path:
protonj2/src/main/java/org/apache/qpid/protonj2/buffer/ProtonBuffer.java
##########
@@ -1220,7 +1220,7 @@
* {@code src.capacity}, or
* if {@code length} is greater than {@code this.writableBytes}
*/
- ProtonBuffer writeBytes(ProtonBuffer source, int sourrceIndex, int length);
+ ProtonBuffer writeBytes(ProtonBuffer source, int sourceIndex, int length);
// TODO rename to offset as in overrides?
Review comment:
Not a spelling error
##########
File path:
protonj2/src/main/java/org/apache/qpid/protonj2/codec/encoders/AbstractDescribedMapTypeEncoder.java
##########
@@ -156,8 +156,8 @@ public void writeArray(ProtonBuffer buffer, EncoderState
state, Object[] values)
// Move back and write the size
final int writeSize = buffer.getWriteIndex() - startIndex -
Integer.BYTES;
- if (writeSize > Integer.MAX_VALUE) {
- throw new IllegalArgumentException("Cannot encode given array,
encoded size to large: " + writeSize);
+ if (writeSize > Integer.MAX_VALUE) { // same, always false
Review comment:
Not a spelling error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
