gemmellr commented on pull request #1: URL: https://github.com/apache/qpid-protonj2/pull/1#issuecomment-907073105
I know Tim definitely shares my distaste of unnecessary multi-commits aimed at the same single effective change (and also, mixing unrelated changes in the same commit/JIRA as I see above hehe) and so would have squashed all the changes together...but maybe not so much my distaste of the superfluous merge commit and so went ahead and merged the squash. I would have either made you squash+rebase before merging it with a simple fast-forward, or edited the commit message to have it close the PR when squashing myself and skip the merge commit. Guesss you know that though, hence the comment :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
