michaelandrepearce commented on a change in pull request #43:
URL: https://github.com/apache/qpid-jms/pull/43#discussion_r711019518
##########
File path:
qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/JmsInitialContextFactory.java
##########
@@ -80,6 +80,14 @@ public Context getInitialContext(Hashtable<?, ?>
environment) throws NamingExcep
String expanded = expand(location, environmentCopy);
if (ProviderFactory.findProviderFactory(new URI(expanded)) !=
null) {
environmentCopy.put(CONNECTION_FACTORY_DEFAULT_KEY_PREFIX
+ REMOTE_URI_PROP, expanded);
+ String principle =
environmentCopy.containsKey(Context.SECURITY_PRINCIPAL) ? (String)
environment.get(Context.SECURITY_PRINCIPAL) :
System.getProperty(Context.SECURITY_PRINCIPAL);
Review comment:
fair enough can strip out the system and leave it just from jndi env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]