[ 
https://issues.apache.org/jira/browse/QPIDJMS-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416695#comment-17416695
 ] 

ASF GitHub Bot commented on QPIDJMS-548:
----------------------------------------

gemmellr commented on pull request #43:
URL: https://github.com/apache/qpid-jms/pull/43#issuecomment-921804323


   Well again, there are ways that dont require putting them in the URL, 
including the very one you used to implement the change under the covers.
   
   If you are saying that the factory.createConnection(user, pass) method 
doesnt work and this does, then that would likely be a bug that should be 
investigated and fixed, but it is not a good reason to add this hack, which I 
still dont intend to.
   
   For what its worth, the createConnection(user, pass) method is tested, and 
it operates by passing the credentials to the client innards in the same field 
as setting them on the factory does, since both are transferred to an 
intermediate object from where they actually get used, its actually the more 
explicitly set of the two, so I dont immediately see how this could make any 
difference at all to what the client does.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Support using principle and credentials from jndi context for default CF when 
> using naming url
> ----------------------------------------------------------------------------------------------
>
>                 Key: QPIDJMS-548
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-548
>             Project: Qpid JMS
>          Issue Type: Improvement
>          Components: qpid-jms-client
>            Reporter: Michael Andre Pearce
>            Priority: Major
>             Fix For: 1.2.0
>
>
> Since QPIDJMS-542 it possible to provide the url on the context via 
> java.naming.provider.url, as an extension / enhancement to this would be to 
> support using the jndi context security principle and security context.
> e.g.
> java.naming.factory.initial=org.apache.qpid.jms.jndi.JmsInitialContextFactory
> java.naming.provider.url=failover:(amqps://host1:5672,amqps://host2:5672)
> java.naming.security.principal=myuser
> java.naming.security.credentials=mypassword
>  
> Would set the user and password on the connection factory to "myuser" and 
> "mypassword" 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to