[
https://issues.apache.org/jira/browse/PROTON-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427102#comment-17427102
] ASF GitHub Bot commented on PROTON-2382: ---------------------------------------- codecov-commenter commented on pull request #336: URL: https://github.com/apache/qpid-proton/pull/336#issuecomment-939987605 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#336](https://codecov.io/gh/apache/qpid-proton/pull/336?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f11fda) into [main](https://codecov.io/gh/apache/qpid-proton/commit/30b245a48d7461fd41854e5bb63eadf19cbb26bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30b245a) will **increase** coverage by `15.58%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-proton/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## main #336 +/- ## =========================================== + Coverage 68.65% 84.23% +15.58% =========================================== Files 351 46 -305 Lines 70755 2341 -68414 =========================================== - Hits 48577 1972 -46605 + Misses 22178 369 -21809 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [ruby/lib/core/message.rb](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9tZXNzYWdlLnJi) | `57.05% <0.00%> (-31.77%)` | :arrow_down: | | [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: | | [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `76.52% <0.00%> (-19.57%)` | :arrow_down: | | [ruby/lib/codec/mapping.rb](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvbWFwcGluZy5yYg==) | `88.17% <0.00%> (-1.08%)` | :arrow_down: | | [cpp/examples/broker.cpp](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL2Jyb2tlci5jcHA=) | | | | [c/tests/raw\_connection\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9yYXdfY29ubmVjdGlvbl90ZXN0LmNwcA==) | | | | [c/tests/fuzz/fuzz-sniff-header.c](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9mdXp6L2Z1enotc25pZmYtaGVhZGVyLmM=) | | | | [c/tests/event\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9ldmVudF90ZXN0LmNwcA==) | | | | [cpp/src/connect\_config.cpp](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb25uZWN0X2NvbmZpZy5jcHA=) | | | | [cpp/src/target.cpp](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy90YXJnZXQuY3Bw) | | | | ... and [296 more](https://codecov.io/gh/apache/qpid-proton/pull/336/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/336?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/336?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [30b245a...8f11fda](https://codecov.io/gh/apache/qpid-proton/pull/336?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] > [cpp] An accessor on tracker for the delivery tag > ------------------------------------------------- > > Key: PROTON-2382 > URL: https://issues.apache.org/jira/browse/PROTON-2382 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding > Reporter: Jiri Daněk > Assignee: Rakhi Kumari > Priority: Major > Fix For: proton-c-0.36.0 > > > * Tracker object should be enhanced to allow accessing the delivery tag. > * Enhance the test to show that both the sender and the receiver are able to > access the delivery tag in all the relevant places where it makes sense. That > is: > ** after the message was sent in the sender, > ** while choosing the disposition in the receiver (see also PROTON-2060), > ** and when the disposition is returned to the sender. > https://github.com/apache/qpid-proton/blob/8ddf5399013b02f1fd13bda3fee7886bd48a98be/cpp/src/handler.cpp#L84-L88 > (Remember that we had difficulties getting {{on_delivery_settle}} to run...) -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
