[
https://issues.apache.org/jira/browse/PROTON-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428427#comment-17428427
]
ASF GitHub Bot commented on PROTON-2382:
----------------------------------------
gemmellr commented on a change in pull request #336:
URL: https://github.com/apache/qpid-proton/pull/336#discussion_r727973563
##########
File path: cpp/src/delivery_test.cpp
##########
@@ -78,12 +79,15 @@ class test_recv : public proton::messaging_handler {
}
void on_message(proton::delivery &d, proton::message &msg) override {
- proton::binary test_tag_recv("TESTTAG");
- ASSERT_EQUAL(test_tag_recv, d.tag());
+ ASSERT_EQUAL(test_tag, d.tag());
d.receiver().close();
d.connection().close();
listener.stop();
}
+
+ void on_delivery_settle(proton::delivery &d) override {
+ ASSERT_EQUAL(test_tag, d.tag());
+ }
Review comment:
I would guess its because the receiver is settling first, not the sender
(the server), so it doesnt make sense for this to ever fire in that case as the
delivery has been forgotten about at that point. (I expect it would typically
only be used in 'receiver settles second' settlement mode, which nothing really
uses).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [cpp] An accessor on tracker for the delivery tag
> -------------------------------------------------
>
> Key: PROTON-2382
> URL: https://issues.apache.org/jira/browse/PROTON-2382
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
> Reporter: Jiri Daněk
> Assignee: Rakhi Kumari
> Priority: Major
> Fix For: proton-c-0.36.0
>
>
> * Tracker object should be enhanced to allow accessing the delivery tag.
> * Enhance the test to show that both the sender and the receiver are able to
> access the delivery tag in all the relevant places where it makes sense. That
> is:
> ** after the message was sent in the sender,
> ** while choosing the disposition in the receiver (see also PROTON-2060),
> ** and when the disposition is returned to the sender.
> https://github.com/apache/qpid-proton/blob/8ddf5399013b02f1fd13bda3fee7886bd48a98be/cpp/src/handler.cpp#L84-L88
> (Remember that we had difficulties getting {{on_delivery_settle}} to run...)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
