mklaca commented on pull request #110:
URL: https://github.com/apache/qpid-broker-j/pull/110#issuecomment-950683148
Hi Alex,
- The original code contains the class AclRulePredicates that consists of
multiple rule predicates. I am not keen on renaming everything. I would like to
keep some continuity in the code.
- The RulePredicate interface is very similar to the
java.util.function.Predicate interface.
- Two rule predicates/conditions can be combined with AND or OR operation.
If I renamed the RulePredicate#and method to RulePredicate#combine than it
would be misleading because it does not specify how they are combined.
- 'Some' rule condition/predicate requires at least some non-null value.
'Any' rule condition/predicate should accept any value including null.
- RulePredicate#and method chains two predicates into one. It has an
important optimization that prevents creating a useless long chain of
predicates that always match for any input.
```
if (other instanceof Any)
{
return this;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
