[
https://issues.apache.org/jira/browse/PROTON-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435349#comment-17435349
]
ASF GitHub Bot commented on PROTON-2382:
----------------------------------------
gemmellr commented on a change in pull request #336:
URL: https://github.com/apache/qpid-proton/pull/336#discussion_r738284530
##########
File path: cpp/src/delivery_test.cpp
##########
@@ -102,8 +102,16 @@ class test_send : public proton::messaging_handler {
void on_sendable(proton::sender &s) override {
proton::message msg;
msg.body("message");
- proton::binary test_tag_send("TESTTAG");
- s.send(msg, test_tag_send);
+ proton::tracker t = s.send(msg, test_tag);
+ ASSERT_EQUAL(test_tag, t.tag());
+ }
+
+ void on_tracker_accept(proton::tracker &t) override {
+ ASSERT_EQUAL(test_tag, t.tag());
+ }
+
+ void on_tracker_settle(proton::tracker &t) override {
+ ASSERT_EQUAL(test_tag, t.tag());
Review comment:
I was about to merge this, but before I did I decided to try and make it
fail. I created a second different tag and modified each assertion in turn to
compare against it rather than the one set set on the send.
It cause the test to fail when the first assertion (right after the send
call) was changed, but the test still passed when the other two were modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [cpp] An accessor on tracker for the delivery tag
> -------------------------------------------------
>
> Key: PROTON-2382
> URL: https://issues.apache.org/jira/browse/PROTON-2382
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
> Reporter: Jiri Daněk
> Assignee: Rakhi Kumari
> Priority: Major
> Fix For: proton-c-0.36.0
>
>
> * Tracker object should be enhanced to allow accessing the delivery tag.
> * Enhance the test to show that both the sender and the receiver are able to
> access the delivery tag in all the relevant places where it makes sense. That
> is:
> ** after the message was sent in the sender,
> ** while choosing the disposition in the receiver (see also PROTON-2060),
> ** and when the disposition is returned to the sender.
> https://github.com/apache/qpid-proton/blob/8ddf5399013b02f1fd13bda3fee7886bd48a98be/cpp/src/handler.cpp#L84-L88
> (Remember that we had difficulties getting {{on_delivery_settle}} to run...)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
