franz1981 edited a comment on pull request #44: URL: https://github.com/apache/qpid-jms/pull/44#issuecomment-953989682
> Ok. It seemed like you wanted to make it the default. I didn't said it clearly on the PR, but I don't want to break existing users code :) https://github.com/apache/qpid-jms/pull/45 is using a ref counted approach that would GC the shared "resource" after all JMSSession that need it have been closed; I'm opened to other approaches, but it's not clear to me (yet) which class should decide the lifecycle of the shared completion thread pool, any idea is welcome eg connection factory finalization looks appealing (on Artemis JMS impl we do that), but I'm not a big fan of finalizers :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
