ted-ross commented on a change in pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414#discussion_r740289989
##########
File path: src/router_core/modules/mobile_sync/mobile.c
##########
@@ -690,8 +690,24 @@ static void qcm_mobile_sync_on_mau_CT(qdrm_mobile_sync_t
*msync, qd_parsed_field
// Tell the python router about the new mobile sequence
//
qdr_post_set_mobile_seq_CT(msync->core, router->mask_bit,
mobile_seq);
- } else
- qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown
router");
+ } else {
+ //
+ // There is a possibility here that router_id is null but that is
fine. We want to print it out either way
+ // which will help us in debugging.
+ //
+ char *r_id = 0;
+ bool free_rid = false;
+ if (id_field) {
+ qd_iterator_t *id_iter = qd_parse_raw(id_field);
+ if (id_iter) {
+ r_id = (char *)qd_iterator_copy(id_iter);
+ free_rid = true;
+ }
+ }
+ qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown
router with router id %s", r_id);
Review comment:
There is a similar log for MAR messages. For completeness, you should
probably add the router_id to that one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
