DreamPearl commented on pull request #338: URL: https://github.com/apache/qpid-proton/pull/338#issuecomment-968864064
@gemmellr > I know Jiri thought, and I agree, that ensuring a test of some kind covers this would be good since obviously nothing existing covered this except the example, and so still doesnt with this as-is. I have written a test to capture the concerning bug if that exists. > Plus that it might also be good to protect the spot where the segfault actually occurred, rather than just the outer segment where the option is passed through to it, so no other routes can hit similar issue in future. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
