astitcher commented on a change in pull request #340:
URL: https://github.com/apache/qpid-proton/pull/340#discussion_r752828384
##########
File path: cpp/include/proton/uuid.hpp
##########
@@ -35,13 +38,20 @@ namespace proton {
/// A 16-byte universally unique identifier.
class uuid : public byte_array<16> {
+
+ private:
+ thread_local static std::independent_bits_engine<std::mt19937, CHAR_BIT,
+ unsigned int>
+ engine;
+ thread_local static std::seed_seq seed;
+
Review comment:
Actually thinking a bit more. It probably doesn't actually change the
ABI. But it does unnecessarily leak implementation details of the uuid class.
IMO it's better to just make these static thread_local in the implementation
file without putting them in the class at all. This will generate pretty much
exactly the same code but is better encapsulated (again IMO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
