DreamPearl commented on pull request #337:
URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-979809877


   > Regardless, I think I would expect this example to have no reference to 
reconnect_options unless non-default values were being set and no call made to 
connection::reconnect().
   
   @cliffjansen Yep, fixed!
   > The segfault appears to be from a missing argument where argc is one short 
to catch the expected number of input parameters. However, it may also be a 
failing in the library to not robustly handle an empty vector properly.
   
   The segfault fix PR is now merged 
[PROTON-2441](https://github.com/apache/qpid-proton/pull/338). It was failing 
in the library, connection_options::failover_urls wasn't able to handle an 
empty vector.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to