kgiusti commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781286944
##########
File path: python/qpid_dispatch/management/qdrouter.json
##########
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
- "default": 16384,
Review comment:
Why have two sets of defaults then (one in the entity's definition in
the schema [e.g. listener], and one in the policy)? My point is defining a
policy should not force another set of defaults when the entity itself defines
its defaults.
Otherwise we're maintaining two sets of defaults which need to be kept in
sync else we trigger this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
