jiridanek commented on a change in pull request #1498:
URL: https://github.com/apache/qpid-dispatch/pull/1498#discussion_r793639170
##########
File path: src/router_core/route_tables.c
##########
@@ -671,8 +671,7 @@ static void qdr_subscribe_CT(qdr_core_t *core, qdr_action_t
*action, bool discar
DEQ_INSERT_TAIL(addr->subscriptions, sub);
qdr_addr_start_inlinks_CT(core, addr);
}
- } else
- free(sub);
+ }
Review comment:
I was not sure if this is safe thing to do, but it probably is: if this
causes problems (=leak), that would mean there is bug somewhere else (maybe
causing the "unsubscribe" action not to be scheduled).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
