jiridanek commented on pull request #1413: URL: https://github.com/apache/qpid-dispatch/pull/1413#issuecomment-1024238237
> > @kgiusti that we'd need devs to be consistent with the use of the new QD_EXPORT qualifier when adding/modifying new declarations in the codebase. > > Yes, that is true. There is a chunk of code in dispatch which IMO tries to resolve all C functions during startup to discover any possible issues. There are functions missing here, mostly things added for protocol adaptors. > > https://github.com/apache/qpid-dispatch/blob/main/python/qpid_dispatch_internal/dispatch.py#L51-L79 For example, `qd_entity_refresh_allocator` is not in the list above, where function signatures get configured. It is not immediately obvious from grepping the codebase this gets called from Python, because the function name is computed at runtime: ```python fname = "qd_entity_refresh_" + entity_type.short_name.replace('.', '_') ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
