jiridanek opened a new pull request #1504:
URL: https://github.com/apache/qpid-dispatch/pull/1504


   I am going to merge this on my own, because these kinds of tasks result in 
quite unreadable and hence unreviewable diffs. I'll try to add inline PR 
comments to explain what's happening, though, so you can review this later, if 
you want. In my experience, maintaining a proper level of sugar and possibly 
certain other sugar-related chemical in your bloodstream makes the work of 
reviewing stuff like this more bearable.
   
   ```
   75: py36 run-test: commands[2] | mypy --config-file 
/home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug-asan/tests/tox.ini 
/home/jdanek/repos/qpid/qpid-dispatch/python 
/home/jdanek/repos/qpid/qpid-dispatch/docs 
/home/jdanek/repos/qpid/qpid-dispatch/tests 
/home/jdanek/repos/qpid/qpid-dispatch/tools 
/home/jdanek/repos/qpid/qpid-dispatch/cmake-build-debug-asan/python/build/lib/qpid_dispatch_site.py
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/hyperh2_server.py:99: error: 
Argument 1 to "int" has incompatible type "Optional[str]"; expected "Union[str, 
bytes, SupportsInt, SupportsIndex, _SupportsTrunc]"  [arg-type]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/http2_slow_q2_server.py:99: 
error: Argument 1 to "int" has incompatible type "Optional[str]"; expected 
"Union[str, bytes, SupportsInt, SupportsIndex, _SupportsTrunc]"  [arg-type]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/system_test.py:367: error: 
Cannot resolve name "Config" (possible cyclic definition)  [misc]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/test_command.py:37: error: 
Cannot assign to a method  [assignment]
   75: 
/home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_topology_disposition.py:48:
 error: Name "Timeout" already defined (possibly by an import)  [no-redef]
   75: 
/home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_topology_addition.py:36:
 error: Name "Timeout" already defined (possibly by an import)  [no-redef]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_topology.py:36: 
error: Name "Timeout" already defined (possibly by an import)  [no-redef]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_ssl.py:120: 
error: Item "None" of "Optional[Match[str]]" has no attribute "group"  
[union-attr]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_ssl.py:138: 
error: Module has no attribute "TLSVersion"  [attr-defined]
   75: 
/home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_sasl_plain.py:679: 
error: Name "ssl_file" already defined on line 606  [no-redef]
   75: 
/home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_qdmanage.py:215: 
error: Name "test_get_attributes" already defined on line 211  [no-redef]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_priority.py:34: 
error: Name "Timeout" already defined (possibly by an import)  [no-redef]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/run_system_tests.py:46: 
error: Unsupported operand types for + ("List[str]" and "TestSuite")  [operator]
   75: /home/jdanek/repos/qpid/qpid-dispatch/tests/TCP_echo_server.py:129: 
error: "None" has no attribute "getsockname"  [attr-defined]
   75: 
/home/jdanek/repos/qpid/qpid-dispatch/tests/system_tests_edge_router.py:2658: 
error: Name "on_released" already defined on line 2541  [no-redef]
   75: Found 15 errors in 14 files (checked 134 source files)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to