astitcher commented on a change in pull request #356:
URL: https://github.com/apache/qpid-proton/pull/356#discussion_r799556735
##########
File path: python/setup.py.in
##########
@@ -145,6 +146,7 @@ class Configure(build_ext):
# pkg-config for a minimum version 0. If it's installed, it should
# return True and we'll use it. Otherwise, we'll use the stub.
if misc.pkg_config_version_installed('openssl', atleast='0'):
+ library_dirs += [misc.pkg_config_get_var('openssl', 'libdir')]
libraries += ['ssl', 'crypto']
Review comment:
Well it's just not the usual way you'd use pkg-config! The essential
point of it is to tell you what extra flags you need in the compile and link
lines to get this library.
It's entirely possible to change what the libraries are called, or add extra
dependency libraries, if you look them up using pkg-config. Specifically in
this case the extra -lcrypto is not really obvious (except that everyone has
just to used to linking it now!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
