ganeshmurthy commented on a change in pull request #1514: URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804115507
########## File path: tests/c_unittests/CMakeLists.txt ########## @@ -20,7 +20,7 @@ # -fno-inline: just to be extra sure, no particular reason so far # -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub # -fno-stack-protector: https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk -# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+, https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning +# -U_FORTIFY_SOURCE: for Ubuntu with -O1+, https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline -fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE") Review comment: Don't you think that it is strange that the RHEL 7 compile line first does -D_FORTIFY_SOURCE=2 and then later on does -U_FORTIFY_SOURCE. It seems to me that it tries to first set and then nullify _FORTIFY_SOURCE. In any case, does any of the upstream CI builds use the -D_FORTIFY_SOURCE ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
