jiridanek commented on a change in pull request #1514: URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804152531
########## File path: tests/c_unittests/CMakeLists.txt ########## @@ -20,7 +20,7 @@ # -fno-inline: just to be extra sure, no particular reason so far # -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub # -fno-stack-protector: https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk -# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+, https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning +# -U_FORTIFY_SOURCE: for Ubuntu with -O1+, https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline -fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE") Review comment: while I think that setting `_FORTIFY_SOURCE` to disable tests is silly and such ideas should not be encouraged, you have a point saying that undefining options the way it's there now is not a good practice thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
