jiridanek opened a new pull request #358: URL: https://github.com/apache/qpid-proton/pull/358
This started as https://issues.apache.org/jira/browse/PROTON-2407 Today, I tried using qpid-proton at HEAD and I haven't found any weird PyCharm warnings caused by the annotations. I mostly used Dispatch tests as examples of user-written programs. There was one annoyance: The time handlers scheduled with `reactor.schedule()` now have to be subclasses of `proton.Handler`, in order to pass typecheck, to not be highlighted in annoying yellow. Other than that, it looked OK. I tried running mypy on qpid-proton (https://issues.apache.org/jira/browse/PROTON-2453), but that did not go well, regarding 'internal consistency' of the type annotations. One thing that I noticed and am repairing here is the `socket.socket` mistake that I made before. To tell the truth, I am not sure what the best next step now is. Probably to clean up what is already there so that mypy is happy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
