bartoval commented on a change in pull request #1517: URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807832047
########## File path: console/react/src/App.js ########## @@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css"; import { QDRService } from "./common/qdrService"; import "./App.css"; import PageLayout from "./overview/dashboard/layout"; -class App extends Component { - state = {}; - - render() { - // service is passed in to make testing easier - const service = new QDRService(); - // also, a router is used here to provide PageLayout with a history property - return ( - <Router> - <div className="App pf-m-redhat-font"> - <Route - path="/" - render={props => ( - <PageLayout service={service} {...props} config={this.props.config} /> - )} - /> - </div> - </Router> - ); - } + +function App(props) { + + // service is passed in to make testing easier + let service = new QDRService(); Review comment: You can safetely use the _const_ keyword instead of _let_ here and in line 39. `const service = new QDRService();` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org